tests: fix FormatDateTime with 32-bit time_t #10344
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a 32-bit time_t, two checks in the FormatDateTime test case didn't work properly so far:
The failing test case was introduced to the support/2.13 branch with #10165, the first affected version is 2.13.11.
backport of #10342
There's a slight change compared to the original PR:
if constexpr
was replaced with a simpleif
to comply with the older C++ standard.