Upgrade to Prettier 3 in dev dependencies #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
changed the title
|
Replaced by #75 |
IanVS
added a commit
that referenced
this pull request
Jul 14, 2023
This PR started with #43, and then merge-conflict resolution was necessary. No big worries about this PR (or your prettier-3 PR), but I did have to fix `run_spec.ts` to get the tests to pass, and I don't know why I had to. -- Please specifically review this commit. 5832d91 (there was no `output` variable in scope, so I guessed!) --------- Co-authored-by: Ian VanSchooten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a test to see whether we're compatible with prettier 3. Initially we were broken, due to prettier/prettier#13729. But that's been addressed in the latest alpha, and tests are now passing.
I think we could merge and release this prior to the next breaking change. The only user-facing change in this PR is to peerDependencies, so that folks can start using prettier 3 if they want. But we might as well hold off, I think, to see how things shake out in prettier, since it sounds like there may be more breaking changes on the way.