Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #8 🎫: transaction form page #14

Merged
merged 11 commits into from
Jan 11, 2024

Conversation

ITurres
Copy link
Owner

@ITurres ITurres commented Jan 11, 2024

TransactionDetailsController

  • Updated before_action 'set_transaction_detail' to destroy only and except create.
  • Filled show action to show transaction_detail.
  • Declared categories and assign all categories to it at 'new' action.
  • Updated create action to create new category and transaction association.
  • Updated destroy action to use flash messages.
  • Updated transaction_detail_params to permit category_id instead of
    user_id.
  • Removed index, show, edit and update actions.

Schema and Migrations

  • Created a new migration file to add :category_id column.
  • Re-migrated schema.rb to reflect changes.

Markup and Styles

  • Updated the new and _form views to match the wireframe style.
  • Deleted the index and _category views.
  • Gave styles to select elements.

Specs

  • Unit specs for controller actions.
  • Integration specs for the new view.

- Update before_action 'set_transaction_detail' to destroy only and except create.
- Fill 'show' action to show transaction_detail.
- Declare categories and assign all categories to it at 'new' action.
- Update 'create' action to create new category and transaction association.
- Update 'destroy' action to use flash messages.
- Update 'transaction_detail_params' to permit category_id instead of
  user_id.
- Remove 'update' action.
- Remove 'edit' action.
- Add on delete cascade to 'category' and 'transaction_detail' columns.
- Re-migrate the table to add the new constraint.
@ITurres ITurres added enhancement New feature or request tests Unit and Integration Tests UI Views UI labels Jan 11, 2024
@ITurres ITurres self-assigned this Jan 11, 2024
@ITurres ITurres linked an issue Jan 11, 2024 that may be closed by this pull request
@ITurres ITurres merged commit 960beec into development Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Unit and Integration Tests UI Views UI
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[3pt] - "Add a new transaction" page (form)
1 participant