Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7 🎫: category form page #13

Merged
merged 7 commits into from
Jan 10, 2024
Merged

Conversation

ITurres
Copy link
Owner

@ITurres ITurres commented Jan 10, 2024

CaegoriesController

  • Updated create action to override icon attr, store current user,
    use flash messages, and redirect to the categories index page.
  • Updated update action to use flash messages and redirect to
    the categories index page.
  • Update destroy action to use flash messages and redirect to
    the categories index page.
  • Removed json and html responses from create, update and destroy actions.
  • Removed show and edit actions.
  • Created a random_icon_color method to generate a random colour for the category icon.
  • Created set_category_icon to use placeholder icons.

Markup and Styles

  • Updated the edit, new and _form views.
  • Styles have been added following the design guidelines. The button's styles have been moved to a separate file buttons.css.

Tests

  • Integration tests for the categories#new view.
  • Unit tests for the categories controller actions.
  • A login_helper file has been created to facilitate the user login for testing.

- Also add new dark green color custom property.
- Update 'create' action to override icon attr, store current user,
  use flash messages, and redirect to categories index page.
- Update 'update' action to use flash messages and redirect to
  categories index page.
- Update 'destroy' action to use flash messages and redirect to
  categories index page.
- Remove json and html responses from 'create', 'update' and 'destroy' actions.
- Remove 'show' and 'edit' actions.
- Create 'random_icon_color' method to generate random color for category icon.
- Create 'set_category_icon' to use placehold icons.
@ITurres ITurres added enhancement New feature or request tests Unit and Integration Tests UI Views UI labels Jan 10, 2024
@ITurres ITurres self-assigned this Jan 10, 2024
@ITurres ITurres linked an issue Jan 10, 2024 that may be closed by this pull request
@ITurres ITurres merged commit 5395007 into development Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Unit and Integration Tests UI Views UI
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[3pt] - "Add a new category" page (form)
1 participant