replace 'ghit' package with 'remotes' #24
Conversation
from 6.1.1. There appears to be a few formatting changes in the autogenerated Rd file
to avoid a Roxygen note when checking package
It was removed from CRAN May 2018. The 'remotes' package has the same functionality (and function names)
Some rules & recommendations have changed. https://github.com/r-lib/covr#codecov
The `after_success` block is still Different. I go the `r_packages` block confused with `r_github_packages`
|
@wibeasley hello! Thank you for this pull request! Have you seen #21 about how dataverse-client-r needs a maintainer? I also posted about this over the summer at https://groups.google.com/d/msg/dataverse-community/j-cGlnpKs14/S3PW3f1MBQAJ I don't know enough R to even properly review this pull request but perhaps @maxheld83 or @ghost or @tmrozewski or @nfultz or others mentioned in #21 can take a look? 😄 🙏 |
|
@pdurbin, it sounds like you're asking if I'm willing to become the package maintainer? If so, 'yes', but I don't want to cut line in front of @maxheld83, @tmrozewski, or @nfultz. (BTW, I think '@ghost' is GitHub's placeholder for a deleted user ... in this case monogan.) I've included some more information in https://groups.google.com/forum/#!msg/dataverse-community/j-cGlnpKs14. |
|
The change to the vignette/travis looks fine to me in terms of getting rid of the old package, although I'd actually recommend just turning off eval for that chunk rather than actually installing anything. |
and use the default notifications, which are mostly what was specified: https://docs.travis-ci.com/user/notifications/#default-notification-settings ref IQSS#25
`usethis::use_coverage()` and other adivce from https://github.com/r-lib/covr ref IQSS#25
and change `R` (in master) to `Rscript` in the `after_success` block ref IQSS#25
(currently Travis's default is Xenial) ref IQSS#25
since knitr is already a 'suggest'ed package, and rmarkdown is a dependency (https://CRAN.R-project.org/package=knitr ). ref IQSS#25
|
https://travis-ci.org/IQSS/dataverse-client-r/builds/606938819 is passing and "master" is broken. I'm merging this. Thanks, @wibeasley 🎉 🎉 🎉 |
Responding to @nfultz's comment at IQSS#24 (comment) https://yihui.name/knitr/options/#chunk-options
The package was removed/archived on CRAN May 2018.
https://cran.r-project.org/package=ghit
The repo says