-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validates client config #1083
Validates client config #1083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atomicgamedeveloper thanks for the PR. Please check the comments.
…cgamedeveloper/DTaaS into 658-validate-client-config
) - Refactors the classes interacting with gitlab so that the exploration of existing digital assets in a gitlab repository are possible - Adds library page which allows to browse existing assets in a gitlab repository and select them to create new digital twin - Adds feature to create digital twins from clean slate - Adds ability to create composite, fleet and hierarchical digital twins --------- Co-authored-by: vanessa <[email protected]>
…on#1102) - Updates the configuration files of libms in docker containers - Updates the documentation to reflect the change. --------- Co-authored-by: prasadtalasila <[email protected]>
- Add guidelines for contributors and their code of conduct - Includes security fixes suggested by dependabot --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atomicgamedeveloper Something has gone wrong with the rebase. Also please check the comments.
@atomicgamedeveloper The codeclimate PR integration is broken. Please follow the temporary fix suggested in #1113. Please close this PR and open a new PR from your |
@atomicgamedeveloper Other suggestions.
PS: I haven't checked the tests yet. |
Title
Validates client config.
Fixes #658
Type of Change
Description
This PR will provide a route to validate the client config file. A comprehensive, manual one for developers, and another one that automatically redirects users in case their config is incorrectly setup or URLs are unreachable.
It will also update the client dependencies. Related to issue #658.
Testing
Manual testing for now.
Impact
Additional Information
None.
Checklist
existing code.