map_data_render.js: placeholders get -1 timestamp value #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can fix issue with recent intel bug, when normal portals (not placeholders) had 0 timestamp value, which lead to wrong data processing, because detailed data was rejected as it considered not fresher than placeholders (that originated from links/fields that currently are processing earlier). https://t.me/iitc_group/8046 Note: this is rather temporary fix, as we need to revise our data procesing approaches in whole. Perhaps, instead of relying on timestamps, we should compare new data details with cached, every single property. There is another issue: ghosted fields, which may be considered as intel (or Ingress) bug, but we still should try to investigate it further, as it may be possible to propose some workaround. Of cause if it will not turn out that Ingress itself is affected in same way (shows same ghosted fields, and prevents linking in that area). For now, just add more logging.
modos189
force-pushed
the
master
branch
3 times, most recently
from
a34b800
to
7b9edd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can fix issue with recent intel bug, when normal portals (not placeholders) had 0 timestamp value,
which lead to wrong data processing, because detailed data was rejected as it considered not fresher than
placeholders (that originated from links/fields that currently are processing earlier).
https://t.me/iitc_group/8046
Note: this is rather temporary fix, as we need to revise our data procesing approaches in whole.
Perhaps, instead of relying on timestamps, we should compare new data details with cached,
every single property.
There is another issue: ghosted fields, which may be considered as intel (or Ingress) bug,
but we still should try to investigate it further, as it may be possible to propose some workaround.
Of cause if it will not turn out that Ingress itself is affected in same way (shows same ghosted fields,
and prevents linking in that area).
For now, just add more logging.
This change is