Skip to content

Conversation

Apricot-ale
Copy link
Contributor

@Apricot-ale Apricot-ale commented Feb 5, 2025

When merged this pull request will:

  • Edit CTS3Client::getConfigFilePath to Fix config path not loaded, error causing by double slash.

Example of Error:

Configuration Path: {C:\Users\%USERNAME%\AppData\Roaming\TS3Client\\acre\acre2.ini}
Failed to load ACRE ini file. Using defaults...

ts3Functions.getConfigPath(tempFolder) is maybe return AppData\Roaming\TS3Client\
\\acre2 is return \acre2
so tempFolder += "\\acre"; is returns AppData\Roaming\TS3Client\\acre

I'm not familiar with C, so please correct me if this is a problem.
Also, I haven't tried this fix yet because I don't know how to build and test the plugin...

getTempFilePath is not related with acre2.ini
it's same as %WinDir%\Temp
@Apricot-ale Apricot-ale changed the title Extensions - Fix acre.ini Configuration Path Extensions - Fix acre2.ini Configuration Path Feb 5, 2025
@jonpas
Copy link
Member

jonpas commented Mar 12, 2025

Double slashes shouldn't be a problem.

@Apricot-ale Apricot-ale reopened this Mar 17, 2025
@Apricot-ale
Copy link
Contributor Author

Apricot-ale commented Mar 17, 2025

Double slashes shouldn't be a problem.

Yes, this isn't a big problem, and the necessary data is included by the fallback.
However, an error is logged every time, and I'm sure acre2.ini cannot be load.

Well, since acre2.ini is no longer needed by anyone, and this PR is mainly to eliminate the error, we might as just remove the entirely acre2.ini things instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants