Skip to content

Fix duplicate-column sorting issue in Text2SQL evaluation utils #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oktie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix duplicate-column sorting issue in Text2SQL evaluation utils #1954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/unitxt/text2sql_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,8 +856,10 @@ def rows_to_multisets(df):

def sort_df(df):
sorted_df = df.copy()
for col in sorted_df.columns:
sorted_df[col] = sorted_df[col].astype(str).sort_values(ignore_index=True)
for i in range(len(sorted_df.columns)):
sorted_df.iloc[:, i] = (
sorted_df.iloc[:, i].astype(str).sort_values(ignore_index=True)
)
return sorted_df

if df1.empty or df2.empty or len(df1) != len(df2):
Expand Down