Conversation
jkeskingvillage
changed the title
ctpelok77
approved these changes
Oct 10, 2025
ctpelok77
requested changes
Oct 13, 2025
| @@ -0,0 +1,9 @@ | |||
| FROM python:3.11 | |||
|
|
|||
| RUN apt-get update && apt-get install -y cmake make g++ | |||
Collaborator
There was a problem hiding this comment.
Why do we need cmake and g++?
Contributor
Author
There was a problem hiding this comment.
This line was supposed to be checked at your pull request for using K* package binary. Did you check it?
|
|
||
| payload = await client.call_tool( | ||
| "KstarPlannerUnorderedTopQ", | ||
| {"domain": domain, "problem": problem}, |
Collaborator
There was a problem hiding this comment.
I think we should explicitly provide the important parameters here without depending on defaults not changing:
quality_bound: float = 1.0,
num_plans: int = 10
If the quality bound changes, there might be more than one plan returned.
Contributor
Author
There was a problem hiding this comment.
This pull request is for establishing the CI pipeline for K* MCP Server nothing else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue:
#23
This pull request implements a continuous integration pipeline for the KMCPServer project using GitHub Actions. The pipeline will:
This automation will help ensure code quality, catch regressions early, and streamline the release process.
To prevent potential naming conflicts with the Python map package, the
mcpfolder has been renamed tomcp_server. This change ensures that the server package and map package can coexist without import errors.The new pipeline was completed successfully.