Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review changes from scripts-dev to scripts-adopter #2207

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Review changes from scripts-dev to scripts-adopter #2207

merged 3 commits into from
Sep 20, 2024

Conversation

github-actions[bot]
Copy link

common service installer automation on 2024-09-19-13-59-30

@qpdpQ
MCSP BR (#2082)
25e6388 
* account-iam db br

Signed-off-by: Allen Li <[email protected]>

* add mcsp br to oadp approach

Signed-off-by: Allen Li <[email protected]>

---------

Signed-off-by: Allen Li <[email protected]>
@github-actions GitHub Actions
Copy link
Author

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign ycshen1010 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot
Copy link
Collaborator

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qpdpQ
usingibm-licensing-service-instance deployment to ensure the exact …
930b87b 
…namespace (#2206)

* `ibm-licensing-service-instance` deployment to ensure the exact namespace

Signed-off-by: Allen Li <[email protected]>

* add detail in error message

Signed-off-by: Allen Li <[email protected]>

---------

Signed-off-by: Allen Li <[email protected]>
@github-actions GitHub Actions
Copy link
Author

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@github-actions GitHub Actions
Copy link
Author

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@github-actions github-actions bot merged commit 7ebe97c into scripts-adopter Sep 20, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluzarraga bluzarraga Awaiting requested review from bluzarraga

@qpdpQ qpdpQ Awaiting requested review from qpdpQ

Assignees
No one assigned
Labels
ok-to-sync size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibm-ci-bot @bluzarraga @qpdpQ