Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Introducing the global variable DRYRUN when the preview mode is enabled. #1383

Open
wants to merge 1 commit into
base: scripts-dev
Choose a base branch
from

Conversation

YCShen1010
Copy link
Contributor

ticket: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/57618

  • Define DRY_RUN="" at the beginning of the script and set DRY_RUN="--dry-run=client" when preview mode is on.
  • Using ${OC} ${DRY_RUN} create/apply instead of instead of OC_CMD="oc --dry-run=client" create/apply

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YCShen1010 YCShen1010 changed the title Introducing the global variable DRYRUN when the preview mode is enabled. [4.2] Introducing the global variable DRYRUN when the preview mode is enabled. Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants