-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add two apple-with-apple tests #625
Conversation
Should these tests be in the pgen/tests directory and so always compiled and always able to run from every executable? Only regression tests, or tests that are run frequently, should be there. Or should they be just in the pgen directory, so that that the code would have to be custom built using the -DPROBLEM='test' option to run them. I'm OK either way, but just want to be sure you really want them implemented as regression-level tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, just have to decide in they should be in /pgen or pgen/tests
@jmstone moved z4c apple-with-apple tests out of the test folders, now ready to be merged! |
Adding robust stability and the gauge wave test. As well as fixing a few bugs, including mismatched variable name and index for the z4c user history output.
Results are attached below:
Minkolski + noise, damping away as expected

1d gauge wave with different order of spatial differencing + RK4, seeing expected order of convergence except at high resolution with high-order methods where the round-off error due to the increased numbers of operations now dominates, giving a negative convergence factor.