Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add two apple-with-apple tests #625

Merged
merged 12 commits into from
Jan 31, 2025
Merged

add two apple-with-apple tests #625

merged 12 commits into from
Jan 31, 2025

Conversation

HengruiZhu99
Copy link
Collaborator

Adding robust stability and the gauge wave test. As well as fixing a few bugs, including mismatched variable name and index for the z4c user history output.

Results are attached below:

Minkolski + noise, damping away as expected
stability

1d gauge wave with different order of spatial differencing + RK4, seeing expected order of convergence except at high resolution with high-order methods where the round-off error due to the increased numbers of operations now dominates, giving a negative convergence factor.

gauge_wave

@jmstone
Copy link
Collaborator

jmstone commented Jan 22, 2025

Should these tests be in the pgen/tests directory and so always compiled and always able to run from every executable? Only regression tests, or tests that are run frequently, should be there. Or should they be just in the pgen directory, so that that the code would have to be custom built using the -DPROBLEM='test' option to run them. I'm OK either way, but just want to be sure you really want them implemented as regression-level tests.

Copy link
Collaborator

@jmstone jmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just have to decide in they should be in /pgen or pgen/tests

@HengruiZhu99
Copy link
Collaborator Author

@jmstone moved z4c apple-with-apple tests out of the test folders, now ready to be merged!

@jmstone jmstone merged commit 49909af into main Jan 31, 2025
4 checks passed
@jmstone jmstone deleted the z4c_tests branch January 31, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants