Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine tests #93

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Refine tests #93

merged 2 commits into from
Jul 21, 2023

Conversation

yishi-ttd
Copy link
Contributor

@yishi-ttd yishi-ttd commented Jul 20, 2023 •
edited
Loading

  1. Fix a typo in OIDC test.
  2. Change new added tests from Junit4 to Junit5.
  3. Make CI run both Junit4 and Junit5. (Lots of existing tests are skipped in CI.)
    • before: Tests run: 39, Failures: 0, Errors: 0, Skipped: 0
    • after: Tests run: 222, Failures: 0, Errors: 0, Skipped: 3

lunwang-ttd
lunwang-ttd approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@lunwang-ttd lunwang-ttd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yishi-ttd yishi-ttd merged commit f6b82fa into master Jul 21, 2023
3 checks passed
@yishi-ttd yishi-ttd changed the title Fix a typo in OIDC test Refine tests Jul 21, 2023
@yishi-ttd yishi-ttd deleted the fix-oidc-typo branch July 21, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunwang-ttd lunwang-ttd lunwang-ttd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yishi-ttd @lunwang-ttd