Do not show UI tour with updates for new users #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleysmithTTD
commented
Nov 4, 2024
| @@ -29,7 +29,7 @@ describe('testing tour storage helper functions', () => { | |||
| mockUser.currentParticipantUserRoles = [{ id: UserRoleId.Admin, roleName: 'Admin' }]; | |||
| mockUser.participants = [mockParticipant, mockParticipant2] as Participant[]; | |||
| mockParticipant.currentUserRoleIds = [UserRoleId.Admin]; | |||
| localStorage.removeItem(tourStorageKey); | |||
| localStorage.setItem(tourStorageKey, JSON.stringify({ seenForVersions: ['0.1.0'] })); | |||
|
|
|||
There was a problem hiding this comment.
Setting it to an early version so it shows all the steps are present - can't leave it empty or it won't show any tour steps
ssundahlTTD
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed:
Note: this check relies on local storage, meaning if a user logs in on a different device or happens to clear their local storage, they would not see the tour steps, but I think it's safe to assume the case is rare where they would log in on a different device or clear their local storage and be needing to see new features for the first time
Test Plan: