Extract participant handlers to separate file #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-yau-ttd
commented
Oct 29, 2024
There was a problem hiding this comment.
Open to suggestions on the name of this file. The convention in this folder is participantsX, where X is another aspect related to participants, e.g. participantsKeyPairs.ts. However, these methods are purely to do with participants themselves.
| const { participant } = req; | ||
| const apiRoles: ApiRoleDTO[] = await getApiRoles(participant!); | ||
| return res.status(200).json(apiRoles); | ||
| }; |
There was a problem hiding this comment.
if we keep the naming of participants which I think is fine, then I think it makes sense for this function to be moved into a new file called participantsApiRoles.ts
ashleysmithTTD
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring only :)