-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check operator version and provide correct presigned url #136
Open
lizk886
wants to merge
55
commits into
main
Choose a base branch
from
wzh-uid2-3574-check-version-update-presignedurl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizk886
changed the title
initial code
check operator version and provide correct presigned url
Jul 23, 2024
Ian-Nara
reviewed
Jul 24, 2024
lizk886
changed the base branch from
main
to
wzh-uid2-3572-s3encryption-keys-distribution-endpoint
July 24, 2024 23:53
thomasm-ttd
reviewed
Aug 1, 2024
Base automatically changed from
wzh-uid2-3572-s3encryption-keys-distribution-endpoint
to
main
August 1, 2024 21:12
…hub.com:IABTechLab/uid2-core into wzh-uid2-3574-check-version-update-presignedurl
cYKatherine
force-pushed
the
wzh-uid2-3574-check-version-update-presignedurl
branch
5 times, most recently
from
August 7, 2024 02:09
88ca356
to
349b3a3
Compare
…hub.com:IABTechLab/uid2-core into wzh-uid2-3574-check-version-update-presignedurl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution 2: get upgraded info by comparing version info in headers. With unit tests.
need to deploy IABTechLab/uid2-shared#314 first ( update the Const.java)
successful build: https://github.com/IABTechLab/uid2-core/actions/runs/10288910692
successful run in integration: