-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UID2-4391 Major refactor to improve performance and maintainability #7
Open
atarassov-ttd
wants to merge
4
commits into
main
Choose a base branch
from
ant-UID2-4391-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atarassov-ttd
commented
Nov 6, 2024
•
edited
Loading
edited
- Removed redundant separation of IO and Worker threads keeping a single pool IO worker threads - Removed memory arena and custom memory management for IO buffers - Removed half-baked support for multiple inflight output buffers - Increased IO buffer size to 1024 bytes - Simplified and cleaned up a lot of code - Removed support for socks proxy in config as this was not an implemented feature - Simplified socket implementation, especially around how sockets get closed in case of errors - Make proxy a bit fairer by round-robining across all connections with a single IO operation at a time, instead of draining each socket in order - Make support for handling async connections more explicit - Add unit test coverage, most importantly - for the sockets IO logic - Improved/corrected README Manually verified through various tests as well as using tcptunnelchecker.
thomasm-ttd
approved these changes
Nov 6, 2024
scong-ttd
approved these changes
Nov 6, 2024
Shall we increase to more based on uid operator payload size? (or make it configurable) |
scong-ttd
reviewed
Nov 6, 2024
That was incorrect statement in the PR description, updated to 4096 which is the final number we settled on based on perf testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.