-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] wagmi switch chain claim error #41
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,13 @@ import { useMutation, useQueryClient } from '@tanstack/react-query' | |
import { useEffect, useState } from 'react' | ||
import { useTranslation } from 'react-i18next' | ||
import { createPublicClient, http } from 'viem' | ||
import { useAccount, useConnect, useSwitchChain, useWriteContract } from 'wagmi' | ||
import { | ||
useAccount, | ||
useConfig, | ||
useConnect, | ||
useSwitchChain, | ||
useWriteContract | ||
} from 'wagmi' | ||
import { injected } from 'wagmi/connectors' | ||
import { ConfirmClaimModal } from '../ConfirmClaimModal' | ||
import styles from './index.module.scss' | ||
|
@@ -58,6 +64,7 @@ export function RewardWrapper({ | |
const { t: tOriginal } = useTranslation() | ||
const account = useAccount() | ||
const { connectAsync } = useConnect() | ||
const config = useConfig() | ||
|
||
// Context | ||
const { | ||
|
@@ -214,15 +221,27 @@ export function RewardWrapper({ | |
|
||
let address: `0x${string}` | undefined | ||
|
||
if (account.address) { | ||
/** | ||
* handles https://github.com/HyperPlay-Gaming/product-management/issues/801 | ||
* Sometimes wagmi does not establish a connection but useAccount returns the address. | ||
* We need to check that the switch chain method exists before proceeding with claiming. | ||
*/ | ||
let connectionHasSwitchChain = false | ||
if (config.state.current) { | ||
const currentConnection = config.state.connections.get( | ||
config.state.current | ||
) | ||
connectionHasSwitchChain = !!currentConnection?.connector.switchChain | ||
} | ||
|
||
if (account.address && connectionHasSwitchChain) { | ||
address = account.address | ||
} else { | ||
onShowMetaMaskPopup?.() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this is needed, but didn't want to slow down this PR. If MM ext sends a notification, the appropriate window will already be shown in the UI. |
||
logInfo('connecting to wallet...') | ||
const { accounts } = await connectAsync({ connector: injected() }) | ||
address = accounts[0] | ||
} | ||
|
||
if (!address) { | ||
throw Error('no address found when trying to mint') | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at their code, it looks like switchChain is not supported by all the connectors https://github.com/wevm/wagmi/blob/main/packages/core/src/connectors/createConnector.ts#L64
if that's the case, then we'd never enter this if clause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it would always throw on line 249 then since we need switch chain to be present to proceed.
If the connector didn't have switch chain, then another connect call would be performed to try and connect to the injected provider which does have
switchChain
. This is our intended UX for now I believe.