Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: add storybook #30

Merged
merged 5 commits into from
Nov 5, 2024
Merged

tech: add storybook #30

merged 5 commits into from
Nov 5, 2024

Conversation

eliobricenov
Copy link
Contributor

@eliobricenov eliobricenov commented Nov 4, 2024 •
edited
Loading

@eliobricenov eliobricenov marked this pull request as ready for review November 4, 2024 20:24
@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quests-ui ✅ Ready (Inspect) Visit Preview Nov 4, 2024 8:25pm

BrettCleary
BrettCleary approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works. might need to add a missing prop as the cta text is not showing
image

@eliobricenov
Copy link
Contributor Author

it works. might need to add a missing prop as the cta text is not showing image

I'll address this in a different PR

@eliobricenov eliobricenov merged commit 123405d into main Nov 5, 2024
2 checks passed
@eliobricenov eliobricenov deleted the feat/add-storybook branch November 5, 2024 00:22
@eliobricenov eliobricenov restored the feat/add-storybook branch November 5, 2024 00:54
@eliobricenov eliobricenov deleted the feat/add-storybook branch November 5, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettCleary BrettCleary BrettCleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliobricenov @BrettCleary