Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quest-details): add support for individual claim click #29

Merged
merged 38 commits into from
Nov 14, 2024

Conversation

eliobricenov
Copy link
Contributor

@eliobricenov eliobricenov commented Oct 28, 2024

Summary

Overall the change is to replace the global claim all logic to individual claim actions for each reward. Story Link

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quests-ui ✅ Ready (Inspect) Visit Preview Nov 14, 2024 0:40am

src/components/QuestDetailsWrapper/index.tsx Outdated Show resolved Hide resolved
src/components/QuestDetailsWrapper/index.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@BrettCleary
Copy link
Contributor

looks like there are a few conflicts now @eliobricenov

Copy link
Contributor

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thx for making the changes. let's ship it and test e2e in the client on your claim branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump the version here by a minor version?

Copy link
Contributor

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/state/ClaimedRewardToastState.ts Outdated Show resolved Hide resolved
@eliobricenov eliobricenov merged commit 2b814b5 into main Nov 14, 2024
2 checks passed
@eliobricenov eliobricenov deleted the feat/claim-quest-page branch November 14, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants