Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Sync state #24

Merged
merged 3 commits into from
Oct 22, 2024
Merged

[Fix] Sync state #24

merged 3 commits into from
Oct 22, 2024

Conversation

BrettCleary
Copy link
Contributor

@BrettCleary BrettCleary commented Oct 22, 2024 •
edited
Loading

Summary

Fix

  • bug where currentPlayTimeInSeconds = 0 causes the quest end timeout to not be set
  • cache time was too long so some quests weren't completed at their end time
  • intervalTimers push
  • console error complaining that fetch query was not returning a value, so now we return null

related to https://github.com/HyperPlay-Gaming/product-management/issues/657

@BrettCleary BrettCleary self-assigned this Oct 22, 2024
@BrettCleary BrettCleary merged commit 24300ac into main Oct 22, 2024
1 check passed
@BrettCleary BrettCleary deleted the fix/sync_state branch October 22, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobricenov eliobricenov eliobricenov approved these changes

Assignees

@BrettCleary BrettCleary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettCleary @eliobricenov