feat(playstreak-sync): add sync button logic #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eliobricenov
commented
Oct 17, 2024
eliobricenov
commented
- shows sync button only if the current user has a pending sync
- disable sync button during mutation
- show success feedback
eliobricenov
commented
Oct 17, 2024
| @@ -25,7 +25,7 @@ | |||
| "types": "dist/index.d.ts", | |||
| "devDependencies": { | |||
| "@hyperplay/chains": "^0.3.0", | |||
| "@hyperplay/ui": "^1.8.0", | |||
| "@hyperplay/ui": "^1.8.4", | |||
There was a problem hiding this comment.
will re-run the build after this version is released
BrettCleary
approved these changes
Oct 17, 2024
| @@ -158,6 +160,63 @@ export function QuestDetailsWrapper({ | |||
| ) | |||
| const questPlayStreakData = questPlayStreakResult.data.data | |||
|
|
|||
| const { | |||
There was a problem hiding this comment.
the quest details wrapper behemoth continues to grow 👹 😄
it would be nice to get in this change HyperPlay-Gaming/hyperplay-ui#396 before we make a bunch of changes to the eligibility criteria components. it is ready for your review when you have time
There was a problem hiding this comment.
I will merge to finalize work on the external data sync for next week's deadline. I already gave a review and like the direction of that PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.