[UI] QuestList card component #427
Open
+393
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Library Details
…or style variants
… tertiary, and error options
…enhance readability
…and integrate Sticker component
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… into ui/quest-list-cards
…ming/hyperplay-ui into ui/quest-list-cards
| display: flex; | ||
| margin-top: 20px; | ||
| align-items: center; | ||
| gap: 0.5rem; |
There was a problem hiding this comment.
can we use spacing var here
src/components/QuestList/types.ts
Outdated
| @@ -0,0 +1,21 @@ | |||
| import { Quest } from '@hyperplay/utils' | |||
There was a problem hiding this comment.
I'm not too opinionated about this but we usually define the props in the same file as the component. For consistency, can you move it to the component file, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to send the new QuestList component hard coded for our Storybook, and after our new auth login is in place we can get the user info about the "Ready for Claim" quests so we can show and finalize the logic for this component in the client.
Design
Design Link
Storybook Link Preview