[Feat] - Improve compatibility layer initialization for Mac and Linux #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x support - Updated `initializeCompatibilityLayer` to include Linux in the compatibility checks. - Renamed `setGPTKDefaultOnMacOS` to `setDefaultCompatibilityLayer` for broader applicability. - Enhanced wine version selection logic to accommodate Proton-GE for Linux and improved compatibility checks for MacOS. - Added early return conditions to streamline the process based on platform compatibility. This refactor improves the overall compatibility layer setup for both Mac and Linux environments.
- Changed the default count for wine version info fetching from 50 to 15 to optimize performance. - Renamed Wine-GE settings to Proton-GE in the WineManager component for clarity and consistency. - Updated the state initialization to reflect the new Proton-GE settings. - Added a condition to refresh wine version info if no versions are available, enhancing user experience.
…desktop-client into feat/make_proton_default
flavioislima
added
PR: Ready-For-Review
flavioislima
requested review from
jiyuu-jin,
BrettCleary,
eliobricenov,
biliesilva and
ry-animal
jiyuu-jin
reviewed
Jan 22, 2025
jiyuu-jin
approved these changes
Jan 22, 2025
ry-animal
approved these changes
Jan 22, 2025
eliobricenov
approved these changes
Jan 22, 2025
flavioislima
added
PR: Ready-For-Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the compatibility layer initialization and wine version management for different platforms. The main changes involve updating the initialization logic for Linux and Mac, modifying the default wine version download criteria, and adjusting the UI settings for the Wine Manager.
It makes Proton-GE default on Linux since Wine-GE is not maintained anymore.
Compatibility Layer Initialization:
src/backend/utils/compatibility_layers.ts: Updated theinitializeCompatibilityLayerfunction to include Linux in the compatibility layer setup and replacedsetGPTKDefaultOnMacOSwith a more genericsetDefaultCompatibilityLayerfunction. [1] [2]Wine Version Management:
src/backend/utils/compatibility_layers.ts: Modified thedownloadDefaultWinefunction to change the criteria for selecting the default wine version on Linux from 'Wine-GE-Proton' to 'Proton-GE'.src/backend/wine/manager/utils.ts: Reduced the default count of wine versions to fetch from 50 to 15 in theupdateWineVersionInfosfunction.UI Adjustments:
src/frontend/screens/WineManager/index.tsx: Updated the Wine Manager UI settings to use 'Proton-GE' instead of 'Wine-GE' for Linux and adjusted the initial state and settings accordingly. Also added a check to refresh wine version information if the list is empty on initial load. [1] [2] [3]HOW TO TEST
Use the following Checklist if you have changed something on the Backend or Frontend: