-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added welsh (cy) #1533
base: main
Are you sure you want to change the base?
Added welsh (cy) #1533
Conversation
Hi, 2 things I'd like to do before changing this draft PR into a complete PR -
|
Not that I know of. Creating all permutations for some languages with support for NumberOfWords, ByteSize, and so on sounds like a lot of information. I wonder if it might be possible to generate that with reflection, though.
As far as I've seen, it's good practice to add some tests with new translations. You're correct that it might seem unnecessary if there's no custom code, but since the strings are also run through Do note that I'm just a random contributor and don't speak in any official capacity for the project. :) |
#1529
Here is a checklist you should tick through before submitting a pull request:
main
branch (more info below)fixes #<the issue number>
build.cmd
orbuild.ps1
and ensure there are no test failures