Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 file storage import #6893

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion label_studio/core/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ def url(self, name, storage_url=False, *args, **kwargs):


class CustomS3Boto3Storage(StorageProxyMixin, S3Boto3Storage):
pass
def url(self, name, storage_url=False, *args, **kwargs):
if storage_url is True:
return super().url(name, *args, **kwargs)
return f"s3://{settings.AWS_STORAGE_BUCKET_NAME}/{name}"


class CustomAzureStorage(StorageProxyMixin, AzureStorage):
Expand Down
2 changes: 1 addition & 1 deletion label_studio/data_import/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def read_task_from_hypertext_body(self):
def read_task_from_uploaded_file(self):
logger.debug('Read 1 task from uploaded file {}'.format(self.filepath))
if settings.CLOUD_FILE_STORAGE_ENABLED:
tasks = [{'data': {settings.DATA_UNDEFINED_NAME: self.filepath}}]
tasks = [{'data': {settings.DATA_UNDEFINED_NAME: self.file.storage.url(self.file.name)}}]
else:
tasks = [{'data': {settings.DATA_UNDEFINED_NAME: self.url}}]
return tasks
Expand Down
Loading