-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: OPTIC-1518: remove a batch of ff #6892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v_4881_timeseries_points_missing_140423_short
…v_5248_double_click_delay_280823_short
…v_5248_double_click_delay_280823_short
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
luarmr
changed the title
Fb optic 1518/remove a batch of ff
refactor: optic-1518: remove a batch of ff
Jan 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6892 +/- ##
===========================================
- Coverage 76.81% 76.80% -0.01%
===========================================
Files 171 171
Lines 14032 14028 -4
===========================================
- Hits 10778 10774 -4
Misses 3254 3254
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luarmr
changed the title
refactor: optic-1518: remove a batch of ff
refactor: OPTIC-1518: remove a batch of ff
Jan 10, 2025
…v_5248_double_click_delay_280823_short
luarmr
force-pushed
the
fb-optic-1518/remove-a-batch-of-ff
branch
from
January 10, 2025 23:38
8784a5e
to
901ef02
Compare
bmartel
approved these changes
Jan 13, 2025
wesleylima
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A group of simple FF that were stale an we dice to remove them in the same pull request to avoid the conflict when merge.
fflag_fix_front_lsdv_4881_timeseries_points_missing_140423_short as True,
fflag_fix_front_lsdv_5248_double_click_delay_280823_short as True
fflag_feat_front_leap_187_video_seek_on_select_short as True
fflag_fix_front_leap_149_taxonomy_selected_true_short as True
You may want to review commit by commit and with whitespace option enabled.
First commit is empty since I create a ticket to group this work