Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-1518: remove a batch of ff #6892

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Jan 10, 2025

A group of simple FF that were stale an we dice to remove them in the same pull request to avoid the conflict when merge.

fflag_fix_front_lsdv_4881_timeseries_points_missing_140423_short as True,
fflag_fix_front_lsdv_5248_double_click_delay_280823_short as True
fflag_feat_front_leap_187_video_seek_on_select_short as True
fflag_fix_front_leap_149_taxonomy_selected_true_short as True

You may want to review commit by commit and with whitespace option enabled.
First commit is empty since I create a ticket to group this work

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit cad09e1
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/678526113f9b480008554d42

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit cad09e1
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67852611a83fac000895bfe4

@luarmr luarmr changed the title Fb optic 1518/remove a batch of ff refactor: optic-1518: remove a batch of ff Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (67eb5f6) to head (cad09e1).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6892      +/-   ##
===========================================
- Coverage    76.81%   76.80%   -0.01%     
===========================================
  Files          171      171              
  Lines        14032    14028       -4     
===========================================
- Hits         10778    10774       -4     
  Misses        3254     3254              
Flag Coverage Δ
pytests 76.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr changed the title refactor: optic-1518: remove a batch of ff refactor: OPTIC-1518: remove a batch of ff Jan 10, 2025
@luarmr luarmr force-pushed the fb-optic-1518/remove-a-batch-of-ff branch from 8784a5e to 901ef02 Compare January 10, 2025 23:38
@luarmr luarmr merged commit 3c03818 into develop Jan 13, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants