Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1708: improve styling for relation overlay #6875

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

Gondragos
Copy link
Collaborator

Added dynamic classes to handle highlighting, ensuring better user interaction and clarity.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

It was hard to distinguish different relations when there are alot of them on the screen.
image

What does this fix?

This fix makes highlighted relation more visible by changing dimmed opacity and moving selected relation into the foreground.
image

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Relations Overlay

Added dynamic classes to handle highlighting, ensuring better user interaction and clarity.
@github-actions github-actions bot added the fix label Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 00d9d47
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6784c61f08fa70000831df8d
😎 Deploy Preview https://deploy-preview-6875--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 00d9d47
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6784c61fd572810008c169c1
😎 Deploy Preview https://deploy-preview-6875--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Jan 13, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/dist/apps/labelstudio/709.js.map

@Gondragos Gondragos merged commit 5660f90 into develop Jan 13, 2025
34 checks passed
@Gondragos Gondragos deleted the fb-leap-1708/improve-relation-highlight branch January 13, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants