[FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE #6870
Conversation
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
There was a problem hiding this comment.
This web/dist dir we discussed earlier in FE Guild that it seems like the gitignore is incorrectly handling the dist directories. Just making a note of that.
There was a problem hiding this comment.
removed and ignored then
There was a problem hiding this comment.
I'm a big proponent of colocating stories files with the component, and leaving storybook to just be the configuration and builder of all the stories across the entire monorepo. I could be convinced this is better, but the one thing I think is a particularly nice aspect of the colocation is that all the NX generators default to this, so scaffolding components can be a very nice way to enforce standards as well as make creating components easier for all. Just a thought.
There was a problem hiding this comment.
makes sense. though, we need to set up components for that first (comment below)
There was a problem hiding this comment.
Is it required to have the path exist as web/libs/ui/src/shad/components/ui/select.tsx for all of these components?
Ideally we would want the code to be organized more like: web/libs/ui/src/components/{component}/{component}.tsx and export the exportable pieces from an index.ts, and colocate other files like tests and stories here.
There was a problem hiding this comment.
this is how shadcn installs components. gotta take a look if we can change that
| @@ -195,3 +195,4 @@ | |||
| } | |||
| } | |||
| } | |||
| <svg width='9'height='5'viewBox='0095'fill='none'xmlns='http://www.w3.org/2000/svg'><path d='M11C10.7238581.223860.51.50.5H7.5C7.776140.580.72385881V3.21922C83.448667.843853.648657.621273.70429L4.621274.4543C4.541654.47424.458354.47424.378734.45429L1.378733.70429L1.257464.18937L1.378733.70429C1.156153.6486513.4486613.21922V1Z'fill='#40A9FF'stroke='#1F1F1F'/></svg> | |||
There was a problem hiding this comment.
was adding this svg here intended?
There was a problem hiding this comment.
This file seems to have been resurrected at the root of the project
There was a problem hiding this comment.
this file shouldn't exist at the root of the project
There was a problem hiding this comment.
There was already a .storybook setup in the UI library, as it is connected to NX generators. Is this a completely separate instance, and where are we canonically going to be configuring and storing our component lib, here? We should consolidate this as I don't believe its intended to have 2 storybook instances (probably just remove the other storybook config and update the commands to run it to point to this one).
| current: "currentColor", | ||
| transparent: "transparent", | ||
| stroke: "#EEEEEE", | ||
| strokedark: "#2D2F40", | ||
| hoverdark: "#252A42", | ||
| titlebg: "#ADFFF8", | ||
| titlebg2: "#FFEAC2", | ||
| titlebgdark: "#24598F", | ||
| btndark: "#292E45", | ||
| white: "#FFFFFF", | ||
| black: "#181C31", | ||
| blackho: "#2C3149", | ||
| blacksection: "#1C2136", | ||
| primaryho: "#0063EC", | ||
| meta: "#20C5A8", | ||
| waterloo: "#757693", | ||
| manatee: "#999AA1", | ||
| alabaster: "#FBFBFB", | ||
| zumthor: "#EDF5FF", | ||
| socialicon: "#D1D8E0", |
There was a problem hiding this comment.
Were you able to discuss the token values with @ricardoantoniocm?
This PR is the first step for Tailwind and Shadcn adoption. It doesn't bring any visual changes at the moment and acts as a foundations for the future work.