-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LEAP-1731: Bulk annotation follow-ups #6867
base: develop
Are you sure you want to change the base?
Conversation
Image preview modal pulled a screen a little when user is zooming the image. Aparently that's the problem of all the modals - they don't block body. Fixed here.
- continue to pan when cursor is out of the image - don't close modal if user released cursor out of the image - user-select: none to always prevent from selection - class component is just more readable
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Could you elaborate more about what issues it fixed? The problem I have with introducing class components is that React going forward is moving further and further from this, and the mindshare is already entirely shifted into hooks being the canonical way to develop with React. As a result this means all main libraries are hooks only, including state management approaches. I would not want to have to be maintaining 2 methods of developing components, so it would have to be a definitive reason to consciously move towards. As for the more readable, that is a subjective take, as I actually see the opposite. What I do agree with is that there are far too many cases of components which happened to use hooks incorrectly which clouds things quite a bit. That is why I framed it more of the mindset that we need to tighten the belt on component best practices, including (must include this) guidance on state management from top to bottom so we don't continue to perpetuate what I consider |
Remove some unused code as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
/git merge develop
|
/git merge
|
UX fixes:
user-select: none
to always prevent from selectionImage Preview is rewritten to be a class component, it's more readable and fixes some issues.
All modals in DM now fixes the window to be non-scrollable — that's usual behaviour for modals and we just missed this.
PR fulfills these requirements
Change has impacts in these area(s)
What feature flags were used to cover this change?
fflag_feat_front_leap_1424_grid_preview_short
Does this PR introduce a breaking change?
All modals in DM are affected, but the fix is very expected.
What level of testing was included in the change?