Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1748: 'Generate labels with AI' button in Project, in SC #6789

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from

Conversation

niklub
Copy link
Collaborator

@niklub niklub commented Dec 13, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

sentry-io bot commented Dec 13, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: label_studio/data_import/functions.py

Function Unhandled Issue
async_import_background ValidationError: ["Failed to parse input file upload/118444/0e166bee-inplace.json: 'int' object is not iterable"] ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 3697f03
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/676d372ca99cce00089710f9

@github-actions github-actions bot added the feat label Dec 13, 2024
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 3697f03
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/676d372c1dda7b0008521f1a

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 73.22835% with 34 lines in your changes missing coverage. Please review.

Project coverage is 76.89%. Comparing base (2e360bc) to head (fc3eab3).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/users/product_tours/serializers.py 54.83% 14 Missing ⚠️
label_studio/users/product_tours/api.py 60.00% 12 Missing ⚠️
label_studio/ml_models/models.py 40.00% 3 Missing ⚠️
label_studio/projects/api.py 83.33% 3 Missing ⚠️
label_studio/projects/models.py 90.90% 1 Missing ⚠️
label_studio/users/product_tours/models.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6789      +/-   ##
===========================================
+ Coverage    76.77%   76.89%   +0.12%     
===========================================
  Files          171      175       +4     
  Lines        14021    14129     +108     
===========================================
+ Hits         10765    10865     +100     
- Misses        3256     3264       +8     
Flag Coverage Δ
pytests 76.89% <73.22%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex robot-ci-heartex self-requested a review December 20, 2024 12:19
label_studio/users/product_tours/models.py Outdated Show resolved Hide resolved
label_studio/projects/models.py Show resolved Hide resolved
label_studio/users/product_tours/api.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants