Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OPTIC-1332: componetize Toggle and Label components #6723

Merged
merged 23 commits into from
Jan 3, 2025
Merged

feat: OPTIC-1332: componetize Toggle and Label components #6723

merged 23 commits into from
Jan 3, 2025
+257 −457

Conversation

carly-bartel
Copy link
Contributor

move Toggle and Label components to new UI folder, replace some instances of usage across LSO

@github-actions github-actions bot added the feat label Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 2ae0ad4
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6777df8b3fd33e00089190e1
😎 Deploy Preview https://deploy-preview-6723--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 2ae0ad4
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6777df8bafe8d50008f9ddf4
😎 Deploy Preview https://deploy-preview-6723--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hlomzik
Copy link
Collaborator

hlomzik commented Nov 26, 2024

I'd suggest to run the code through both linters we have to fix some basic issues.
Also naming is not consistent, please make all files camel-cased.

@yyassi-heartex
Copy link
Contributor

yyassi-heartex commented Nov 29, 2024 •
edited by robot-ci-heartex
Loading

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/editor/LSF.init.md

hlomzik
hlomzik requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use correct cases and classnames for components in ui lib — they should set an example

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Dec 3, 2024 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: create mode 100644 docs/themes/v2/source/images/templates-misc/multipage_nav2.png

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Dec 4, 2024 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 2 files changed, 2 insertions(+), 2 deletions(-)

@yyassi-heartex
Copy link
Contributor

yyassi-heartex commented Dec 16, 2024 •
edited by robot-ci-heartex
Loading

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/frontend-test/src/helpers/utils/fixLSParams.ts

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Dec 17, 2024 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 1 file changed, 1 insertion(+), 1 deletion(-)

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Dec 18, 2024 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 12 files changed, 30 insertions(+), 17 deletions(-)

@yyassi-heartex
Copy link
Contributor

yyassi-heartex commented Jan 3, 2025 •
edited by robot-ci-heartex
Loading

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/datamanager/src/components/MainView/GridView/ImagePreview.tsx

@yyassi-heartex yyassi-heartex merged commit 281ef77 into develop Jan 3, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyassi-heartex yyassi-heartex yyassi-heartex left review comments

@bmartel bmartel bmartel approved these changes

@MihajloHoma MihajloHoma MihajloHoma approved these changes

@hlomzik hlomzik hlomzik approved these changes

Assignees
No one assigned
Labels
Confirmed feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@carly-bartel @hlomzik @yyassi-heartex @MihajloHoma @bmartel @robot-ci-heartex