Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OPTIC-1332: componetize Toggle and Label components #6723

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

carly-bartel
Copy link
Contributor

move Toggle and Label components to new UI folder, replace some instances of usage across LSO

@github-actions github-actions bot added the feat label Nov 26, 2024
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit f79f6e4
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6762bed60cd1570008c0ef09

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit f79f6e4
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6762bed6be47ee000980f29a

@hlomzik
Copy link
Collaborator

hlomzik commented Nov 26, 2024

I'd suggest to run the code through both linters we have to fix some basic issues.
Also naming is not consistent, please make all files camel-cased.

@yyassi-heartex
Copy link
Contributor

yyassi-heartex commented Nov 29, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/editor/LSF.init.md

Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use correct cases and classnames for components in ui lib — they should set an example

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Dec 3, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 docs/themes/v2/source/images/templates-misc/multipage_nav2.png

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Dec 4, 2024

/git merge

Workflow run
Successfully merged: 2 files changed, 2 insertions(+), 2 deletions(-)

@yyassi-heartex
Copy link
Contributor

yyassi-heartex commented Dec 16, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/frontend-test/src/helpers/utils/fixLSParams.ts

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Dec 17, 2024

/git merge

Workflow run
Successfully merged: 1 file changed, 1 insertion(+), 1 deletion(-)

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Dec 18, 2024

/git merge

Workflow run
Successfully merged: 12 files changed, 30 insertions(+), 17 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants