You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted a number of Block and Elem elements to div/span or what ever provided tag and use cn to preserve classnames/styling
this is the primary improvement in this PR
Updated image cell and Annotation Preview to use div with background image instead of img element - wrapped in FF
not sure this helps - might undo this one
web/libs/datamanager/src/components/Common/Form/Form.jsx slight refactor to figure out class name once and apply it in loop
web/libs/datamanager/src/components/MainView/GridView/GridView.jsx added an onChange to reduce console error noise - no negative impact
Cleared out console logging for interfaces to reduce noise and to prevent array from logging in console which can have an impact on performance
web/libs/datamanager/src/stores/AppStore.js yield load task replaced with a promise.then - this addressed and error in console when moving fast enough about potential memory leaks
web/libs/datamanager/src/utils/bem.tsx took out some properties being assigned which don’t seem to be used - wrapped in FF just in case
web/libs/editor/src/components/App/App.jsx added a check for taskHistory length as it was causing an error when clicked - if button doesn’t work no need to display it
web/libs/editor/src/components/BottomBar/Controls.tsx added keys to reduce console error noise due to keys not set
web/libs/editor/src/components/InstructionsModal/InstructionsModal.tsx replaced visible with open to reduce noise in console
PR fulfills these requirements
Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Tests for the changes have been added/updated (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
Self-reviewed and ran all changes on a local instance (for bug fixes/features)
Change has impacts in these area(s)
(check all that apply)
Product design
Backend (Database)
Backend (API)
Frontend
Describe the reason for change
resolving issues that are leading to memory leaks which reduce performance as the user works with application over time
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block
andElem
elements to div/span or what ever provided tag and usecn
to preserve classnames/stylingweb/libs/datamanager/src/components/Common/Form/Form.jsx
slight refactor to figure out class name once and apply it in loopweb/libs/datamanager/src/components/MainView/GridView/GridView.jsx
added an onChange to reduce console error noise - no negative impactweb/libs/datamanager/src/stores/AppStore.js
yield load task replaced with a promise.then - this addressed and error in console when moving fast enough about potential memory leaksweb/libs/datamanager/src/utils/bem.tsx
took out some properties being assigned which don’t seem to be used - wrapped in FF just in caseweb/libs/editor/src/components/App/App.jsx
added a check for taskHistory length as it was causing an error when clicked - if button doesn’t work no need to display itweb/libs/editor/src/components/BottomBar/Controls.tsx
added keys to reduce console error noise due to keys not setweb/libs/editor/src/components/InstructionsModal/InstructionsModal.tsx
replaced visible with open to reduce noise in consolePR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
resolving issues that are leading to memory leaks which reduce performance as the user works with application over time