Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-361: Fix LS build #5018

Closed
wants to merge 8 commits into from
Closed

fix: LEAP-361: Fix LS build #5018

wants to merge 8 commits into from

Conversation

juliosgarbi
Copy link
Contributor

@juliosgarbi juliosgarbi commented Nov 8, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

A change was done to make the files on the current env the same as the files from monorepo, and it started to break the build probably some config on webpack config that makes it work on monorepo but break on current env

What does this fix?

rolled back the changed that was done

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit c3e977d
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/654b8e98e9d79900089a287e

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit c3e977d
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/654b8e985ed1f600075a967d

@github-actions github-actions bot added the fix label Nov 8, 2023
@juliosgarbi juliosgarbi closed this Nov 8, 2023
@hlomzik hlomzik deleted the fb-leap-361 branch November 8, 2023 13:58
@juliosgarbi
Copy link
Contributor Author

It was fixed on #5019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants