dcp-954 fix hca_bionetwork schema url #1526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release from staging to master 2023-05-22
schema url (`describedBy`) pattern was incorrect
amnonkhen
changed the title
ESapenaVentura
requested changes
Jun 30, 2023
There was a problem hiding this comment.
It's missing writing the changes in the update_log.csv - Also not sure if the human-readable markdowns have been generated
Here is a document with the specifics on what is expected that is done during an update https://github.com/HumanCellAtlas/metadata-schema/blob/master/docs/committers.md#specific-how-to-for-making-changes, but we can discuss on monday if it's unclear!
hannes-ucsc
requested changes
Jun 30, 2023
amnonkhen
changed the title
hannes-ucsc
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema url (
describedBy) pattern was incorrect.ebi-ait/dcp-ingest-central#954
Fixes: #1527
Related to: #1517