Skip to content

Add timeout to HubSpotHttpError#252

Merged
camden11 merged 1 commit intomainfrom
improve-timeout-error-messaging
Apr 2, 2025
Merged

Add timeout to HubSpotHttpError#252
camden11 merged 1 commit intomainfrom
improve-timeout-error-messaging

Conversation

@camden11
Copy link
Contributor

@camden11 camden11 commented Apr 2, 2025

Description and Context

This adds the timeout field from AxiosError to HubSpotHttpError, so that the CLI can check it and determine if timeouts were caused by the config default timeout.

Who to Notify

@brandenrodgers @joe-yeager @kemmerle

Copy link
Contributor

@kemmerle kemmerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camden11 camden11 merged commit 64de5c1 into main Apr 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants