Convert errorHandlers to TypeScript #1251
Conversation
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
There was a problem hiding this comment.
I think a good rule to follow in these Typescript PRs is to never cast unless you absolutely have to - 99% of the time there's a better way and not letting yourself cast will force you to find it! I'm always around if you have any questions about that kind of stuff.
Also, it looks like your commits from your last PR got included here, i'm assuming this is because we are now squashing commits and you need to rebase off main (unfortunately i haven't worked with squash commits in a bit and I forget exactly how to do that)
kemmerle
force-pushed
the
convert/ts-3
branch
from
a80e1d6
to
1af6ee7
Compare
| cause: isAxiosError(error.cause) | ||
| ? error.cause | ||
| : util.inspect(error.cause, false, null, true), | ||
| cause: util.inspect(error.cause, false, null, true), |
There was a problem hiding this comment.
Looks like I'm coming in after a few rounds of reviews (so apologies if this was already covered), but is this functionally equivalent to what it did before?
Description and Context
I've converted the files located in the
lib/errorHandlersfolder.Problem with eslint as been addressed 👍
TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager