-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elevate support to hs project create
and helpful info for hs fetch
#1184
base: main
Are you sure you want to change the base?
Conversation
…n, and project create
hs project create
and helpful info for hs fetch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case of hs fetch @hubspot/elevate
outside of a project folder - instead of "Would you like to continue fetching without creating a project? [y/N]", would it be feasible to ask "Would you like to create one? [Y/n]", and then "re-route" them to the hs project create
flow without making them retype a command?
Otherwise code seems good!
packages/cli/lang/en.lyaml
Outdated
@@ -1064,6 +1066,8 @@ en: | |||
logFeedbackMessage: | |||
feedbackHeader: "We'd love to hear your feedback!" | |||
feedbackMessage: "How are you liking the new projects and developer tools? \n > Run `{{#yellow}}hs feedback{{/yellow}}` to let us know what you think!\n" | |||
errors: | |||
downloadFileOrFolder: "Not all files in folder \"{{ src }}\" were successfully fetched. Run `{{#yellow}}{{ command }}{{/yellow}}` again to finish download" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the uiAccountDescription
util here to format the command.
@joeyblake, out of curiosity, why didn't you include the elevate theme template in the |
Oh, we're going to, the PR is here 😁 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
@joeyblake, I meant that you can move the source code for the Elevate theme directly into the EDIT: Nevermind! This comment became moot after the CMS Sync today (10/8). I think the Elevate theme has too many files for the GitHub endpoints to handle reliably. |
Description and Context
The new HubSpot Elevate theme requires a HubSpot project to run. This feature consists of 3 parts.
hs project create
that will create a new HubSpot project withno-template
and thenhs fetch
the Elevate theme into the newly scaffolded project. This also includes a helpful error message in the event that fetching fails to get all of the files the first time.hs fetch @hubspot/elevate
to let the user know that Elevate requires a project to work, that allows the user to continue fetching the files if desired,** If the fetch destination is already an HS project, this prompt will not show and fetching with proceed as normal.
To test
yarn hs fetch @hubspot/elevate <somedestination that is not a project>
yarn hs fetch @hubspot/elevate <somedestination that is in a project folder>
<- nested folders of a project will work tooyarn hs project create --templateSource "joeyblake/hubspot-project-components"
the templateSource will stub in the elevate option into the project create choices.TODO
Who to Notify
@TanyaScales @jsines