Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

refactor: buttonType and ButtonVariant are identical. Using ButtonType #731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cmargieson
Copy link

Button.tsx imports identical ButtonVariant and ButtonType interfaces. Use ButtonType from interface file
alongside component.

Changes proposed in this pull request:

  • Import ButtonType types from interface file in component folder.
  • Keep ButtonVariant around as it is used in other components (for now).

Button.tsx imports identical ButtonVariant and ButtonType interfaces. Use ButtonType from interface
alongsied component.
@CLAassistant
Copy link

CLAassistant commented Mar 31, 2021

CLA assistant check
All committers have signed the CLA.

@cmargieson cmargieson closed this Mar 31, 2021
@cmargieson
Copy link
Author

WIP

@cmargieson cmargieson reopened this Mar 31, 2021
@cmargieson
Copy link
Author

No need to differentiate between ButtonVariant and ButtonType in Button.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants