Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: use stable tag. #839

Merged
merged 1 commit into from
Mar 14, 2024
Merged

install: use stable tag. #839

merged 1 commit into from
Mar 14, 2024

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Mar 14, 2024

Currently we always install onto the latest master. Instead, let's correctly use the latest tag.

See also Homebrew/brew#16891

Currently we always install onto the latest `master`. Instead,
let's correctly use the latest tag.
@vitorgalvao
Copy link
Member

vitorgalvao commented Mar 14, 2024

Should the “untar anywhere” instructions be updated as well, for parity? Though I can see the argument that the extra complication that could add to the command isn’t worth it in support terms.

@MikeMcQuaid
Copy link
Member Author

Though I can see the argument that the extra complication that could add to the command isn’t worth it in support terms.

Yeh, that's my thinking really. It'll get fixed the first time you run brew update anyway.

@Bo98
Copy link
Member

Bo98 commented Mar 14, 2024

Also fixes #829 I think?

@Bo98
Copy link
Member

Bo98 commented Mar 14, 2024

update.sh technically does refs/tags/${LATEST_GIT_TAG} to avoid any name clash, though not sure if that matters much.

@MikeMcQuaid
Copy link
Member Author

update.sh technically does refs/tags/${LATEST_GIT_TAG} to avoid any name clash, though not sure if that matters much.

@Bo98 yeh, can't see it mattering here but can update if it does!

Thanks all!

@MikeMcQuaid MikeMcQuaid merged commit 8eb0339 into master Mar 14, 2024
3 checks passed
@MikeMcQuaid MikeMcQuaid deleted the install_tag branch March 14, 2024 16:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants