Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include first error message in GitHub annotation #1221

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Sep 14, 2024

The first error message is often found before the last 256 lines, so
isn't included in the annotation.

Let's adjust #truncate_output so it includes this error message if
found instead. Searching for error messages is a little naive, but it
matches the way clang, gcc, and rustc print error messages. We can
make this more sophisticated later if desired.

lib/step.rb Show resolved Hide resolved
lib/step.rb Outdated Show resolved Hide resolved
The first error message is often found before the last 256 lines, so
isn't included in the annotation.

Let's adjust `#truncate_output` so it includes this error message if
found instead. Searching for error messages is a little naive, but it
matches the way `clang`, `gcc`, and `rustc` print error messages. We can
make this more sophisticated later if desired.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab merged commit 451d938 into master Sep 16, 2024
4 checks passed
@carlocab carlocab deleted the include-error-annotation branch September 16, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants