Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sile: switch to [email protected] #66142

Closed
wants to merge 1 commit into from

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Dec 3, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Attempted follow up to #65993 (also see backstory comments in #65976, #57133, and upstream issue №1115). SILE is fully compatible with Lua 5.4 so there shouldn't be any need to hold it back on 5.3 except the hassle of figuring out dependencies. This is my (blind) stab at that.

@BrewTestBot BrewTestBot added the lua Lua use is a significant feature of the PR or issue label Dec 3, 2020
@alerque alerque marked this pull request as ready for review December 3, 2020 09:53
@carlocab
Copy link
Member

carlocab commented Dec 3, 2020

Oh, huh. If I had known it was that simple, I'd have done it already. 😄

I left it on 5.3 because I wanted to read the bit32 docs (at least, the installation part of it) before trying, to make sure I'd install it properly.

Turns out that was unnecessary!

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alerque ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@alerque
Copy link
Contributor Author

alerque commented Dec 3, 2020

@carlocab It's not too complicated because like almost every other resource there this just leaves luarocks in charge of figuring out how to install it—i.e. upstream is responsible for setting up the build and install properly. The only exception ones are ones that need special values passed in at build time to interface with system libraries, which bit32 doesn't need.

@carlocab
Copy link
Member

carlocab commented Dec 3, 2020

Thanks for saving me the trouble of having to go back for this!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 3, 2021
@alerque alerque deleted the sile-lua-54 branch April 18, 2022 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lua Lua use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants