Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeling, dynet, eigen, foma: conflicts_with + licenses #59716

Closed
wants to merge 1 commit into from

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Aug 16, 2020

freeling installs its own copies of the other formulae, due to internal patches and concerns about usability: TALP-UPC/FreeLing#90 (comment)

Also added license for eigen and fixed it for foma and freeling.

In support of #59707

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

`freeling` installs its own copies of `dynet`, `eigen` and `foma`.

Also added `license` for `eigen` and fixed it for `foma` and `freeling`.
SMillerDev
SMillerDev previously approved these changes Aug 17, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review August 17, 2020 10:14

bottle publish failed

@gromgit gromgit requested a review from SMillerDev August 18, 2020 10:32
SMillerDev
SMillerDev previously approved these changes Aug 18, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review August 18, 2020 11:15

bottle publish failed

@gromgit
Copy link
Member Author

gromgit commented Aug 18, 2020

@SMillerDev, is it just me, or is something going very subtly wrong with the CI?

@SMillerDev
Copy link
Member

I don't think it's subtle 😅

@gromgit
Copy link
Member Author

gromgit commented Aug 19, 2020

Hmmm, the upload step seems to trip over a possibly-corrupt ZIP:

==> Downloading https://api.github.com/repos/Homebrew/homebrew-core/actions/artifacts/14258841/zip
/usr/bin/curl --disable --globoff --show-error --user-agent Linuxbrew/2.4.12-27-gb932299\ \(Linux\;\ x86_64\ Ubuntu\ 18.04.4\ LTS\)\ curl/7.58.0 --fail --progress-bar --silent --retry 3 --location --create-dirs --output /home/runner/.cache/Homebrew/downloads/aa8020de8d58e850484bc5c94799eae629a206797a40cb59ac47a6c06fc13e36--artifact.zip.incomplete https://api.github.com/repos/Homebrew/homebrew-core/actions/artifacts/14258841/zip --header Authorization:\ token\ ******
unzip -qq -o /home/runner/.cache/Homebrew/downloads/aa8020de8d58e850484bc5c94799eae629a206797a40cb59ac47a6c06fc13e36--artifact.zip -d /tmp/d20200818-2602-e0wal1
Error: Failure while executing; `unzip -qq -o /home/runner/.cache/Homebrew/downloads/aa8020de8d58e850484bc5c94799eae629a206797a40cb59ac47a6c06fc13e36--artifact.zip -d /tmp/d20200818-2602-e0wal1` exited with 9. Here's the output:
[/home/runner/.cache/Homebrew/downloads/aa8020de8d58e850484bc5c94799eae629a206797a40cb59ac47a6c06fc13e36--artifact.zip]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /home/runner/.cache/Homebrew/downloads/aa8020de8d58e850484bc5c94799eae629a206797a40cb59ac47a6c06fc13e36--artifact.zip or
        /home/runner/.cache/Homebrew/downloads/aa8020de8d58e850484bc5c94799eae629a206797a40cb59ac47a6c06fc13e36--artifact.zip.zip, and cannot find /home/runner/.cache/Homebrew/downloads/aa8020de8d58e850484bc5c94799eae629a206797a40cb59ac47a6c06fc13e36--artifact.zip.ZIP, period.

I'll try splitting this into separate PRs for each formula, to see if it solves that hiccup.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@gromgit gromgit deleted the freeling_conflicts branch August 19, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants