Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p11-kit: Versioning fixes. #5434

Closed

Conversation

RandomDSdevel
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)? (N/A: This is a formula revision.)

Moves v0.23.2 of p11-kit to devel status and (correctly) gives v0.22.1 of the software stable status.

Moves v0.23.2 of p11-kit to `devel` status and (correctly) gives v0.22.1 of the software `stable` status.
@RandomDSdevel
Copy link
Contributor Author

RandomDSdevel commented Sep 30, 2016

@dunn, @ilovezfs, @DomT4, @toonetown, @dwmw2, @MikeMcQuaid, @nmav: Here's that PR I promised to submit in my comments (relevant ones starting hereabouts) on the 'p11-kit: add 0.23.2 bottle.' commit. (I '@'-mentioned all of you folks 'cause you've all been involved with un-Boneyarding/updating p11-kit in some form or another.)

@MikeMcQuaid
Copy link
Member

Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@DomT4
Copy link
Member

DomT4 commented Oct 1, 2016

We may end up reverting this depending on how the resolution to 46be01e goes. Still awaiting something from upstream there 😕.

@nmav
Copy link

nmav commented Oct 3, 2016

I am not p11-kit upstream but my suggestion would be to use the latest versions released. The new versions of gnutls already require 0.23.1 (and as David mentioned, you don't want to rely on earlier releases since they do not support new features of rfc7512).

@dwmw2
Copy link

dwmw2 commented Oct 3, 2016

Note, we also want p11-kit to build with p11-kit-proxy.so. See (misplaced) discussion with @mouse07410 in Yubico/yubico-piv-tool#94

@RandomDSdevel
Copy link
Contributor Author

@MikeMcQuaid: You're very welcome! (Sorry for the response, delay, though; I've been away from my setup for a couple of days.)

@RandomDSdevel RandomDSdevel deleted the p11-kit_versioning_fixes branch October 3, 2016 19:13
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants