Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected]: add missing sysconfig inreplace #193308

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[email protected]: add missing sysconfig inreplace #193308

merged 2 commits into from
Oct 9, 2024

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Follow up to #182840 with a few things that were missed

@github-actions github-actions bot added the legacy Relates to a versioned @ formula label Oct 9, 2024
carlocab
carlocab reviewed Oct 9, 2024
View reviewed changes
Formula/p/[email protected] Show resolved Hide resolved
Formula/p/[email protected] Show resolved Hide resolved
@branchvincent branchvincent added the ready to merge PR can be merged once CI is green label Oct 9, 2024
carlocab
carlocab approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised that the test works on Linux, but ok.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 9, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 9, 2024
Merged via the queue into Homebrew:master with commit 430d839 Oct 9, 2024
15 checks passed
@branchvincent branchvincent deleted the python3.13 branch October 9, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. legacy Relates to a versioned @ formula ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@branchvincent @carlocab @BrewTestBot