Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libphonenumber: remove unused dependencies #183903

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

re2 isn't enabled by default - https://github.com/google/libphonenumber/blob/master/cpp/CMakeLists.txt#L89

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Sep 8, 2024
@github-actions github-actions bot added java Java use is a significant feature of the PR or issue boost Boost use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Sep 8, 2024
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Sep 8, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 8, 2024
Merged via the queue into master with commit 3970889 Sep 8, 2024
23 checks passed
@BrewTestBot BrewTestBot deleted the libphonenumber-deps branch September 8, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles icu4c ICU use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants