Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gstreamer: enable webrtc plugin by default #183884

Closed
wants to merge 2 commits into from
Closed

gstreamer: enable webrtc plugin by default #183884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdbc9ee
gstreamer: enable webrtc plugin by default
razvanphp Sep 7, 2024
18f09f2
libnice: use this when compiling gstreamer instead of fetching source
razvanphp Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Formula/g/gstreamer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ class Gstreamer < Formula
depends_on "json-glib"
depends_on "lame"
depends_on "libass"
depends_on "libnice"
carlocab marked this conversation as resolved.
Show resolved Hide resolved
depends_on "libogg"
depends_on "libpng"
depends_on "libshout"
Expand Down Expand Up @@ -169,7 +170,8 @@ def install
-Dpython.purelibdir=#{site_packages}
-Dpython=enabled
-Dlibav=enabled
-Dlibnice=disabled
-Dlibnice=enabled
-Dlibnice-gstreamer-only=true
-Dbase=enabled
-Dgood=enabled
-Dugly=enabled
Expand Down Expand Up @@ -199,6 +201,7 @@ def install
-Dgst-plugins-bad:opencv=disabled
-Dgst-plugins-bad:sctp=enabled
-Dgst-plugins-bad:sctp-internal-usrsctp=disabled
-Dgst-plugins-bad:webrtc=enabled
-Dgst-plugins-good:soup=enabled
-Dgst-plugins-rs:closedcaption=enabled
-Dgst-plugins-rs:dav1d=enabled
Expand Down Expand Up @@ -281,6 +284,8 @@ def caveats
system bin/"gst-inspect-1.0", "--plugin", "x264"
system bin/"gst-inspect-1.0", "--plugin", "rtspclientsink"
system bin/"gst-inspect-1.0", "--plugin", "rsfile"
system bin/"gst-inspect-1.0", "--plugin", "nice"
system bin/"gst-inspect-1.0", "--plugin", "webrtc"
system bin/"gst-inspect-1.0", "hlsdemux2"
end
end
Expand Down
12 changes: 10 additions & 2 deletions Formula/lib/libnice.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ class Libnice < Formula
sha256 "a5f724cf09eae50c41a7517141d89da4a61ec9eaca32da4a0073faed5417ad7e"
license any_of: ["LGPL-2.1-only", "MPL-1.1"]

stable do
# break libnice circular dependancy with gstreamer
# https://github.com/Homebrew/homebrew-core/pull/183884
patch do
url "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/raw/2c3d8e8e0c9a566331f127ab071b5b7c84b33def/subprojects/packagefiles/libnice-0.1.22/add-option-build-only-gstreamer.patch"
sha256 "32768e39b041f91a4ca805dc0a7ed10986a712ce6ac27f78c54274006d6c7920"
end
end

livecheck do
url "https://github.com/libnice/libnice.git"
regex(/^v?(\d+(?:\.\d+)+)$/i)
Expand All @@ -26,7 +35,6 @@ class Libnice < Formula

depends_on "glib"
depends_on "gnutls"
depends_on "gstreamer"

on_macos do
depends_on "gettext"
Expand All @@ -37,7 +45,7 @@ class Libnice < Formula
end

def install
system "meson", "setup", "build", *std_meson_args
system "meson", "setup", "build", "-Dgstreamer=disabled", *std_meson_args
system "meson", "compile", "-C", "build", "--verbose"
system "meson", "install", "-C", "build"
end
Expand Down
Loading