Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate formulae to openssl@3 #133144

Closed
wants to merge 13 commits into from
Closed

Migrate formulae to openssl@3 #133144

wants to merge 13 commits into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jun 8, 2023

Let's try this again.

  • openssl@3: link to HOMEBREW_PREFIX
  • libevent: switch to openssl@3
  • libpq: switch to openssl@3
  • node: switch to openssl@3
  • [email protected]: switch to openssl@3

@carlocab carlocab added the openssl-3-migration Related to switching to an OpenSSL 3 dependency label Jun 8, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 8, 2023
@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. labels Jun 8, 2023
@carlocab
Copy link
Member Author

carlocab commented Jun 8, 2023

Test failure for node:

  npm verb stack FetchError: request to https://registry.npmjs.org/npm failed, reason: unable to get local issuer certificate

Ideas, @Homebrew/core?

@EricFromCanada
Copy link
Member

brew test --verbose node worked just now on macOS 12/arm, maybe it was an issue on their end?

@carlocab
Copy link
Member Author

carlocab commented Jun 9, 2023

brew test --verbose node worked just now on macOS 12/arm, maybe it was an issue on their end?

Did it work after rebuilding against openssl@3, though?

@carlocab
Copy link
Member Author

carlocab commented Jun 9, 2023

The node failure didn't go away unfortunately.

@carlocab carlocab added the help wanted Task(s) needing PRs from the community or maintainers label Jun 9, 2023
@EricFromCanada
Copy link
Member

EricFromCanada commented Jun 9, 2023

Re-testing using openssl@3 on macOS 13/arm + Xcode 14.3.1 was successful:

shell output
% sw_vers
ProductName:		macOS
ProductVersion:		13.3.1
BuildVersion:		22E261

% brew deps node
brotli
c-ares
ca-certificates
icu4c
libnghttp2
libuv
openssl@3

% brew test -v node
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/bin/bundle clean
==> Testing node
==> /opt/homebrew/Cellar/node/20.3.0_1/bin/node /private/tmp/node-test-20230609-49361-wt5hsa/test.js
==> /opt/homebrew/Cellar/node/20.3.0_1/bin/node -e 'console.log(new Intl.NumberFormat("en-EN").format(1234.56))'
==> /opt/homebrew/Cellar/node/20.3.0_1/bin/node -e 'console.log(new Intl.NumberFormat("de-DE").format(1234.56))'
==> /opt/homebrew/bin/npm -ddd --cache=/Users/serveradmin/Library/Caches/Homebrew/npm_cache --build-from-source install npm@latest
npm verb cli /opt/homebrew/Cellar/node/20.3.0_1/bin/node /opt/homebrew/bin/npm
npm info using [email protected]
npm info using [email protected]
npm verb title npm install npm@latest
npm verb argv "--loglevel" "silly" "--cache" "/Users/serveradmin/Library/Caches/Homebrew/npm_cache" "--build-from-source" "install" "npm@latest"
npm verb logfile logs-max:10 dir:/Users/serveradmin/Library/Caches/Homebrew/npm_cache/_logs/2023-06-09T15_37_31_140Z-
npm verb logfile /Users/serveradmin/Library/Caches/Homebrew/npm_cache/_logs/2023-06-09T15_37_31_140Z-debug-0.log
npm sill logfile done cleaning log files
npm http fetch GET 200 https://registry.npmjs.org/npm 8ms (cache hit)
npm sill idealTree buildDeps
npm sill fetch manifest [email protected]
npm sill placeDep ROOT [email protected] OK for:  want: 9.7.1
npm sill reify moves {}
npm sill ADD node_modules/npm

added 1 package in 626ms

27 packages are looking for funding
  run `npm fund` for details
npm verb exit 0
npm info ok 
==> /opt/homebrew/bin/npm -ddd --cache=/Users/serveradmin/Library/Caches/Homebrew/npm_cache --build-from-source install ref-napi
npm verb cli /opt/homebrew/Cellar/node/20.3.0_1/bin/node /opt/homebrew/bin/npm
npm info using [email protected]
npm info using [email protected]
npm verb title npm install ref-napi
npm verb argv "--loglevel" "silly" "--cache" "/Users/serveradmin/Library/Caches/Homebrew/npm_cache" "--build-from-source" "install" "ref-napi"
npm verb logfile logs-max:10 dir:/Users/serveradmin/Library/Caches/Homebrew/npm_cache/_logs/2023-06-09T15_37_31_877Z-
npm verb logfile /Users/serveradmin/Library/Caches/Homebrew/npm_cache/_logs/2023-06-09T15_37_31_877Z-debug-0.log
npm sill idealTree buildDeps
npm sill fetch manifest ref-napi@*
npm sill logfile done cleaning log files
npm http fetch GET 200 https://registry.npmjs.org/ref-napi 24ms (cache hit)
npm sill placeDep ROOT [email protected] OK for:  want: *
npm sill fetch manifest debug@^4.1.1
npm sill fetch manifest get-symbol-from-current-process-h@^1.0.2
npm sill fetch manifest node-addon-api@^3.0.0
npm sill fetch manifest node-gyp-build@^4.2.1
npm http fetch GET 200 https://registry.npmjs.org/debug 5ms (cache hit)
npm http fetch GET 200 https://registry.npmjs.org/node-addon-api 5ms (cache hit)
npm http fetch GET 200 https://registry.npmjs.org/node-gyp-build 6ms (cache hit)
npm http fetch GET 200 https://registry.npmjs.org/get-symbol-from-current-process-h 6ms (cache hit)
npm sill placeDep ROOT [email protected] OK for: [email protected] want: ^4.1.1
npm sill fetch manifest [email protected]
npm sill placeDep ROOT [email protected] OK for: [email protected] want: ^1.0.2
npm sill placeDep ROOT [email protected] OK for: [email protected] want: ^3.0.0
npm sill placeDep ROOT [email protected] OK for: [email protected] want: ^4.2.1
npm http fetch GET 200 https://registry.npmjs.org/ms 2ms (cache hit)
npm sill placeDep ROOT [email protected] OK for: [email protected] want: 2.1.2
npm sill reify moves {}
npm sill audit bulk request {
npm sill audit   npm: [ '9.7.1' ],
npm sill audit   'ansi-regex': [ '6.0.1', '5.0.1' ],
npm sill audit   'emoji-regex': [ '9.2.2', '8.0.0' ],
npm sill audit   'string-width': [ '5.1.2', '4.2.3' ],
npm sill audit   'strip-ansi': [ '7.0.1', '6.0.1' ],
npm sill audit   '@npmcli/fs': [ '3.1.0', '2.1.2' ],
npm sill audit   abbrev: [ '2.0.0', '1.1.1' ],
npm sill audit   'ansi-styles': [ '4.3.0', '6.2.1' ],
npm sill audit   'are-we-there-yet': [ '4.0.0', '3.0.1' ],
npm sill audit   'brace-expansion': [ '2.0.1', '1.1.11' ],
npm sill audit   cacache: [ '17.1.2', '16.1.3' ],
npm sill audit   which: [ '2.0.2', '3.0.1' ],
npm sill audit   debug: [ '4.3.4' ],
npm sill audit   ms: [ '2.1.2', '2.1.3' ],
npm sill audit   'fs-minipass': [ '3.0.2', '2.1.0' ],
npm sill audit   gauge: [ '5.0.1', '4.0.4' ],
npm sill audit   glob: [ '10.2.4', '8.1.0', '7.2.3' ],
npm sill audit   'lru-cache': [ '7.18.3', '9.1.1', '6.0.0' ],
npm sill audit   'make-fetch-happen': [ '11.1.1', '10.2.1' ],
npm sill audit   minimatch: [ '9.0.0', '5.1.6', '3.1.2' ],
npm sill audit   minipass: [ '5.0.0', '3.3.6' ],
npm sill audit   'minipass-fetch': [ '3.0.3', '2.1.2' ],
npm sill audit   nopt: [ '6.0.0', '7.1.0' ],
npm sill audit   npmlog: [ '6.0.2', '7.0.1' ],
npm sill audit   'readable-stream': [ '3.6.2', '4.4.0' ],
npm sill audit   'signal-exit': [ '3.0.7', '4.0.2' ],
npm sill audit   ssri: [ '9.0.1', '10.0.4' ],
npm sill audit   'unique-filename': [ '2.0.1', '3.0.0' ],
npm sill audit   'unique-slug': [ '3.0.0', '4.0.0' ],
npm sill audit   'wrap-ansi': [ '8.1.0', '7.0.0' ],
npm sill audit   'ref-napi': [ '3.0.3' ],
npm sill audit   'get-symbol-from-current-process-h': [ '1.0.2' ],
npm sill audit   'node-addon-api': [ '3.2.1' ],
npm sill audit   'node-gyp-build': [ '4.6.0' ],
npm sill audit   '@colors/colors': [ '1.5.0' ],
npm sill audit   '@gar/promisify': [ '1.1.3' ],
npm sill audit   '@isaacs/cliui': [ '8.0.2' ],
npm sill audit   '@isaacs/string-locale-compare': [ '1.1.0' ],
npm sill audit   '@npmcli/arborist': [ '6.2.9' ],
npm sill audit   '@npmcli/config': [ '6.2.0' ],
npm sill audit   '@npmcli/disparity-colors': [ '3.0.0' ],
npm sill audit   '@npmcli/git': [ '4.1.0' ],
npm sill audit   '@npmcli/installed-package-contents': [ '2.0.2' ],
npm sill audit   '@npmcli/map-workspaces': [ '3.0.4' ],
npm sill audit   '@npmcli/metavuln-calculator': [ '5.0.1' ],
npm sill audit   '@npmcli/move-file': [ '2.0.1' ],
npm sill audit   '@npmcli/name-from-folder': [ '2.0.0' ],
npm sill audit   '@npmcli/node-gyp': [ '3.0.0' ],
npm sill audit   '@npmcli/package-json': [ '3.1.1' ],
npm sill audit   '@npmcli/promise-spawn': [ '6.0.2' ],
npm sill audit   '@npmcli/query': [ '3.0.0' ],
npm sill audit   '@npmcli/run-script': [ '6.0.2' ],
npm sill audit   '@pkgjs/parseargs': [ '0.11.0' ],
npm sill audit   '@sigstore/protobuf-specs': [ '0.1.0' ],
npm sill audit   '@tootallnate/once': [ '2.0.0' ],
npm sill audit   '@tufjs/canonical-json': [ '1.0.0' ],
npm sill audit   '@tufjs/models': [ '1.0.4' ],
npm sill audit   'abort-controller': [ '3.0.0' ],
npm sill audit   'agent-base': [ '6.0.2' ],
npm sill audit   agentkeepalive: [ '4.3.0' ],
npm sill audit   'aggregate-error': [ '3.1.0' ],
npm sill audit   aproba: [ '2.0.0' ],
npm sill audit   archy: [ '1.0.0' ],
npm sill audit   'balanced-match': [ '1.0.2' ],
npm sill audit   'base64-js': [ '1.5.1' ],
npm sill audit   'bin-links': [ '4.0.1' ],
npm sill audit   'binary-extensions': [ '2.2.0' ],
npm sill audit   buffer: [ '6.0.3' ],
npm sill audit   builtins: [ '5.0.1' ],
npm sill audit   chalk: [ '5.2.0' ],
npm sill audit   chownr: [ '2.0.0' ],
npm sill audit   'ci-info': [ '3.8.0' ],
npm sill audit   'cidr-regex': [ '3.1.1' ],
npm sill audit   'clean-stack': [ '2.2.0' ],
npm sill audit   'cli-columns': [ '4.0.0' ],
npm sill audit   'cli-table3': [ '0.6.3' ],
npm sill audit   clone: [ '1.0.4' ],
npm sill audit   'cmd-shim': [ '6.0.1' ],
npm sill audit   'color-convert': [ '2.0.1' ],
npm sill audit   'color-name': [ '1.1.4' ],
npm sill audit   'color-support': [ '1.1.3' ],
npm sill audit   columnify: [ '1.6.0' ],
npm sill audit   'common-ancestor-path': [ '1.0.1' ],
npm sill audit   'concat-map': [ '0.0.1' ],
npm sill audit   'console-control-strings': [ '1.1.0' ],
npm sill audit   'cross-spawn': [ '7.0.3' ],
npm sill audit   cssesc: [ '3.0.0' ],
npm sill audit   defaults: [ '1.0.4' ],
npm sill audit   delegates: [ '1.0.0' ],
npm sill audit   depd: [ '2.0.0' ],
npm sill audit   diff: [ '5.1.0' ],
npm sill audit   eastasianwidth: [ '0.2.0' ],
npm sill audit   encoding: [ '0.1.13' ],
npm sill audit   'env-paths': [ '2.2.1' ],
npm sill audit   'err-code': [ '2.0.3' ],
npm sill audit   'event-target-shim': [ '5.0.1' ],
npm sill audit   events: [ '3.3.0' ],
npm sill audit   'fastest-levenshtein': [ '1.0.16' ],
npm sill audit   'foreground-child': [ '3.1.1' ],
npm sill audit   'fs.realpath': [ '1.0.0' ],
npm sill audit   'function-bind': [ '1.1.1' ],
npm sill audit   'graceful-fs': [ '4.2.11' ],
npm sill audit   has: [ '1.0.3' ],
npm sill audit   'has-unicode': [ '2.0.1' ],
npm sill audit   'hosted-git-info': [ '6.1.1' ],
npm sill audit   'http-cache-semantics': [ '4.1.1' ],
npm sill audit   'http-proxy-agent': [ '5.0.0' ],
npm sill audit   'https-proxy-agent': [ '5.0.1' ],
npm sill audit   'humanize-ms': [ '1.2.1' ],
npm sill audit   'iconv-lite': [ '0.6.3' ],
npm sill audit   ieee754: [ '1.2.1' ],
npm sill audit   'ignore-walk': [ '6.0.3' ],
npm sill audit   imurmurhash: [ '0.1.4' ],
npm sill audit   'indent-string': [ '4.0.0' ],
npm sill audit   'infer-owner': [ '1.0.4' ],
npm sill audit   inflight: [ '1.0.6' ],
npm sill audit   inherits: [ '2.0.4' ],
npm sill audit   ini: [ '4.1.0' ],
npm sill audit   'init-package-json': [ '5.0.0' ],
npm sill audit   ip: [ '2.0.0' ],
npm sill audit   'ip-regex': [ '4.3.0' ],
npm sill audit   'is-cidr': [ '4.0.2' ],
npm sill audit   'is-core-module': [ '2.12.0' ],
npm sill audit   'is-fullwidth-code-point': [ '3.0.0' ],
npm sill audit   'is-lambda': [ '1.0.1' ],
npm sill audit   isexe: [ '2.0.0' ],
npm sill audit   jackspeak: [ '2.2.0' ],
npm sill audit   'json-parse-even-better-errors': [ '3.0.0' ],
npm sill audit   'json-stringify-nice': [ '1.1.4' ],
npm sill audit   jsonparse: [ '1.3.1' ],
npm sill audit   'just-diff': [ '6.0.2' ],
npm sill audit   'just-diff-apply': [ '5.5.0' ],
npm sill audit   libnpmaccess: [ '7.0.2' ],
npm sill audit   libnpmdiff: [ '5.0.17' ],
npm sill audit   libnpmexec: [ '6.0.0' ],
npm sill audit   libnpmfund: [ '4.0.17' ],
npm sill audit   libnpmhook: [ '9.0.3' ],
npm sill audit   libnpmorg: [ '5.0.4' ],
npm sill audit   libnpmpack: [ '5.0.17' ],
npm sill audit   libnpmpublish: [ '7.3.0' ],
npm sill audit   libnpmsearch: [ '6.0.2' ],
npm sill audit   libnpmteam: [ '5.0.3' ],
npm sill audit   libnpmversion: [ '4.0.2' ],
npm sill audit   'minipass-collect': [ '1.0.2' ],
npm sill audit   'minipass-flush': [ '1.0.5' ],
npm sill audit   'minipass-json-stream': [ '1.0.1' ],
npm sill audit   'minipass-pipeline': [ '1.2.4' ],
npm sill audit   'minipass-sized': [ '1.0.3' ],
npm sill audit   minizlib: [ '2.1.2' ],
npm sill audit   mkdirp: [ '1.0.4' ],
npm sill audit   'mute-stream': [ '1.0.0' ],
npm sill audit   negotiator: [ '0.6.3' ],
npm sill audit   'node-gyp': [ '9.3.1' ],
npm sill audit   'normalize-package-data': [ '5.0.0' ],
npm sill audit   'npm-audit-report': [ '5.0.0' ],
npm sill audit   'npm-bundled': [ '3.0.0' ],
npm sill audit   'npm-install-checks': [ '6.1.1' ],
npm sill audit   'npm-normalize-package-bin': [ '3.0.1' ],
npm sill audit   'npm-package-arg': [ '10.1.0' ],
npm sill audit   'npm-packlist': [ '7.0.4' ],
npm sill audit   'npm-pick-manifest': [ '8.0.1' ],
npm sill audit   'npm-profile': [ '7.0.1' ],
npm sill audit   'npm-registry-fetch': [ '14.0.5' ],
npm sill audit   'npm-user-validate': [ '2.0.0' ],
npm sill audit   once: [ '1.4.0' ],
npm sill audit   'p-map': [ '4.0.0' ],
npm sill audit   pacote: [ '15.1.3' ],
npm sill audit   'parse-conflict-json': [ '3.0.1' ],
npm sill audit   'path-is-absolute': [ '1.0.1' ],
npm sill audit   'path-key': [ '3.1.1' ],
npm sill audit   'path-scurry': [ '1.9.1' ],
npm sill audit   'postcss-selector-parser': [ '6.0.13' ],
npm sill audit   'proc-log': [ '3.0.0' ],
npm sill audit   process: [ '0.11.10' ],
npm sill audit   'promise-all-reject-late': [ '1.0.1' ],
npm sill audit   'promise-call-limit': [ '1.0.2' ],
npm sill audit   'promise-inflight': [ '1.0.1' ],
npm sill audit   'promise-retry': [ '2.0.1' ],
npm sill audit   promzard: [ '1.0.0' ],
npm sill audit   'qrcode-terminal': [ '0.12.0' ],
npm sill audit   read: [ '2.1.0' ],
npm sill audit   'read-cmd-shim': [ '4.0.0' ],
npm sill audit   'read-package-json': [ '6.0.3' ],
npm sill audit   'read-package-json-fast': [ '3.0.2' ],
npm sill audit   retry: [ '0.12.0' ],
npm sill audit   rimraf: [ '3.0.2' ],
npm sill audit   'safe-buffer': [ '5.1.2' ],
npm sill audit   'safer-buffer': [ '2.1.2' ],
npm sill audit   semver: [ '7.5.1' ],
npm sill audit   'set-blocking': [ '2.0.0' ],
npm sill audit   'shebang-command': [ '2.0.0' ],
npm sill audit   'shebang-regex': [ '3.0.0' ],
npm sill audit   sigstore: [ '1.5.2' ],
npm sill audit   'smart-buffer': [ '4.2.0' ],
npm sill audit   socks: [ '2.7.1' ],
npm sill audit   'socks-proxy-agent': [ '7.0.0' ],
npm sill audit   'spdx-correct': [ '3.2.0' ],
npm sill audit   'spdx-exceptions': [ '2.3.0' ],
npm sill audit   'spdx-expression-parse': [ '3.0.1' ],
npm sill audit   'spdx-license-ids': [ '3.0.13' ],
npm sill audit   string_decoder: [ '1.1.1' ],
npm sill audit   tar: [ '6.1.14' ],
npm sill audit   'text-table': [ '0.2.0' ],
npm sill audit   'tiny-relative-date': [ '1.3.0' ],
npm sill audit   treeverse: [ '3.0.0' ],
npm sill audit   'tuf-js': [ '1.1.6' ],
npm sill audit   'util-deprecate': [ '1.0.2' ],
npm sill audit   'validate-npm-package-license': [ '3.0.4' ],
npm sill audit   'validate-npm-package-name': [ '5.0.0' ],
npm sill audit   'walk-up-path': [ '3.0.1' ],
npm sill audit   wcwidth: [ '1.0.1' ],
npm sill audit   'wide-align': [ '1.1.5' ],
npm sill audit   wrappy: [ '1.0.2' ],
npm sill audit   'write-file-atomic': [ '5.0.1' ],
npm sill audit   yallist: [ '4.0.0' ]
npm sill audit }
npm info run [email protected] install node_modules/ref-napi node-gyp-build
npm http fetch POST 200 https://registry.npmjs.org/-/npm/v1/security/advisories/bulk 198ms
npm sill audit report {}
npm info run [email protected] install { code: 0, signal: null }
npm sill ADD node_modules/ms
npm sill ADD node_modules/node-gyp-build
npm sill ADD node_modules/node-addon-api
npm sill ADD node_modules/get-symbol-from-current-process-h
npm sill ADD node_modules/debug
npm sill ADD node_modules/ref-napi

added 6 packages, and audited 268 packages in 3s

27 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
npm verb exit 0
npm info ok 
==> /opt/homebrew/bin/npx --yes cowsay hello
npm notice 
npm notice New minor version of npm available! 9.6.7 -> 9.7.1
npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.7.1
npm notice Run npm install -g [email protected] to update!
npm notice 

@carlocab
Copy link
Member Author

carlocab commented Jun 9, 2023

Hmm; I wonder if this is Homebrew/homebrew-test-bot#805.

@Bo98
Copy link
Member

Bo98 commented Jun 9, 2023

Will try take a look on Sunday if no progress has been made by then but:

Hmm; I wonder if this is Homebrew/homebrew-test-bot#805.

if you think it's this then adding some debug output to the test to print whether the file exists should give you an idea.

@carlocab
Copy link
Member Author

carlocab commented Jun 9, 2023

I dropped the commit modifying openssl@3 and node is OK now. Definitely sounds like Homebrew/homebrew-test-bot#805.

@Bo98
Copy link
Member

Bo98 commented Jun 9, 2023

Do we need to modify OpenSSL 3 in this pull request?

@carlocab
Copy link
Member Author

No, not really, which is why I dropped it.

@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jun 10, 2023
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed help wanted Task(s) needing PRs from the community or maintainers labels Jun 11, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 11, 2023
@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 12, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 12, 2023
carlocab added a commit to Homebrew/homebrew-test-bot that referenced this pull request Jun 12, 2023
Trying to fetch a just-built dependency will result in a `brew fetch`
failure because its bottle will not have been uploaded yet.

See Homebrew/homebrew-core#133144.
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jun 12, 2023
This is needed for use as a dependency of `curl`. See Homebrew#133144.
@carlocab carlocab mentioned this pull request Jun 12, 2023
6 tasks
@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 12, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 12, 2023
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. labels Jun 12, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 13, 2023
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 13, 2023
@carlocab
Copy link
Member Author

Let dependent tests run briefly just to see how they look. I'm seeing lots of Python ModuleNotFoundErrors. Not really sure why...

@carlocab
Copy link
Member Author

Closing in favour of #134260.

@carlocab carlocab closed this Jun 20, 2023
@carlocab carlocab deleted the openssl-migration branch June 20, 2023 18:17
@carlocab carlocab mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. openssl-3-migration Related to switching to an OpenSSL 3 dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants